Skip to content

1423: Add "Last Modified" column to Glossary#1428

Merged
ocean90 merged 11 commits into
GlotPress:developfrom
pedro-mendonca:glossary-last-modified
Sep 12, 2022
Merged

1423: Add "Last Modified" column to Glossary#1428
ocean90 merged 11 commits into
GlotPress:developfrom
pedro-mendonca:glossary-last-modified

Conversation

@pedro-mendonca

@pedro-mendonca pedro-mendonca commented May 4, 2022

Copy link
Copy Markdown
Member

This PR already includes the data-sorter for tablesorter added on #1426

  • Add Last Modified column to Glossary
  • Add data-sorter to column to set as sorteable
  • Add timestamp data-text to row data to sort alphabetically
  • Format data and time both in row and editor
  • Fix timezone offset

Fixes #1423

@pedro-mendonca pedro-mendonca requested a review from ocean90 May 4, 2022 13:21
@pedro-mendonca pedro-mendonca force-pushed the glossary-last-modified branch from 5e88add to 9e140e5 Compare July 13, 2022 14:59
@pedro-mendonca

Copy link
Copy Markdown
Member Author

This PR still requires a build step for the .min.css, should I build and add for review?

@ocean90 ocean90 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes related to date handling.

Comment thread gp-templates/glossary-entry-row.php Outdated
Comment thread gp-templates/glossary-entry-row.php Outdated
Comment thread gp-templates/glossary-entry-row.php Outdated
Comment thread gp-templates/glossary-entry-row.php Outdated
@ocean90 ocean90 added this to the 4.0 milestone Sep 10, 2022
@ocean90 ocean90 added the [Type] Enhancement A suggestion for improvement. label Sep 10, 2022
@pedro-mendonca

Copy link
Copy Markdown
Member Author

All suggestions applied, done.

Comment thread gp-templates/glossary-entry-row.php Outdated
@ocean90 ocean90 force-pushed the glossary-last-modified branch from ed015ca to a857e72 Compare September 12, 2022 06:37
@ocean90 ocean90 merged commit 3363095 into GlotPress:develop Sep 12, 2022
@pedro-mendonca pedro-mendonca deleted the glossary-last-modified branch September 12, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a column showing the date when an entry has been added to the glossary

2 participants