Conversation
Since prodash switched over to Jiff, Jiff has grown support for the "friendly" duration format. It is meant to be a replacement for `humantime` formatting of durations.
389e9ed to
88d3399
Compare
|
Thanks so much for your continued and timely support, it's much appreciated! That's exactly what I was looking for when getting this PR ready for merging, so once again, perfect timing :D. With these out of my system, I don't know if it was always so precise, but think that such details can be tackled at a time when displaying durations in the terminal becomes important. 
Thanks again! |
|
PS: I really like that the code became so much simpler thanks to the change! |
|
Nice! And yeah, from my read of it, If and when you do want to tweak it, Jiff has a lot of options for rounding durations and controlling the largest/smallest units. Happy to field questions there! |
This PR bumps to
jiff 0.2and removeshumantimein favor ofjiff.Back when I first contributed the change to move to Jiff
in #31, Jiff didn't have a way of formatting durations
like
humantimedoes. But Jiff does support thatnow.
One part I'm a little unsure about here is that prodash was still
trying to emit times even when
local-timewasn't enabled, and itwas using
humantimeto do this. But now that Jiff is used for boththings, it probably doesn't make sense to have this fallback. (I think
it's also somewhat suspicious, since printing UTC time as if it were
local time is likely confusing.) In any case, I left it as it was,
except with using Jiff.
I tried running tests locally, but one of the tui rendering tests just
hung indefinitely for me.