Closed
Conversation
Previously, when traversing commits, we would assume to be in a shallow repository if a commit's parent could not be found in the repository. Now we validate that assumption by reading the 'shallow' file to check if the last seen commit is on the commit boundary. This removes `is_shallow` and `error_on_missing_commit()` on the `revision::walk::Platform` as shallow commits are now known and handled without any guesswork.
Member
Author
|
already merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
GIT_SHALLOW_FILEenvironment variable available via config - it's useful for hooks where this file isn't settled yet (and generally environment variables are used for this kind of thing).git/shallow.git/shallowfilevalidate that the 'commit not founds' during iteration is actually a grafted commit and fail otherwiseremove special handling of guessed shallow commits - instead make it work properly.