gix-error conversion batch 1 (part 1) by Byron · Pull Request #2423 · GitoxideLabs/gitoxide

Byron · 2026-02-07T18:17:30Z

Crates done

1 gix-bitmap # feat!: gix-error instead of thiserror in gix-bitmap
2 gix-quote # feat!: gix-error instead of thiserror in gix-quote
3 gix-mailmap # feat!: gix-error instead of thiserror in gix-mailmap

Batch 1 Migration Complete

11 crates migrated from thiserror to gix-error, in 11 commits:
┌────────────────┬───────────────────────────────────────────────────────┬─────────────────────────────────────────────────────────────────────────┐
│     Crate      │                 Error types replaced                  │                            Downstream fixes                             │
├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
│ gix-bitmap     │ 1 (ewah::decode::Error)                               │ none                                                                    │
├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
│ gix-quote      │ 1 (ansi_c::undo::Error)                               │ none                                                                    │
├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
│ gix-mailmap    │ 1 (parse::Error)                                      │ none                                                                    │
├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
│ gix-fs         │ 1 (to_normal_path_components::Error)                  │ none                                                                    │
├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
│ gix-lock       │ 1 (acquire::Error)                                    │ gix-testtools                                                           │
├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
│ gix-path       │ 2 (relative_path::Error, realpath::Error)             │ gix-ref                                                                 │
├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
│ gix-packetline │ 3 (encode::Error, decode::Error, decode::band::Error) │ none                                                                    │
├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
│ gix-attributes │ 2 (name::Error, parse::Error)                         │ gix-pathspec                                                            │
├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
│ gix-url        │ 3 (parse::Error, UrlParseError, expand_path::Error)   │ gix-transport, gix                                                      │
├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
│ gix-hash       │ 7 (all error types)                                   │ gix-object, gix-pack, gix-odb, gix-index, gix-status, gix-protocol, gix │
├────────────────┼───────────────────────────────────────────────────────┼─────────────────────────────────────────────────────────────────────────┤
│ gix-features   │ 3 (DecompressError, CompressError, inflate::Error)    │ (included in gix-hash downstream)                                       │
└────────────────┴───────────────────────────────────────────────────────┴─────────────────────────────────────────────────────────────────────────┘
Verification: cargo check -p gix passes, all 21 test suites across the 11 crates pass with 0 failures.

Tasks

fixup commits with correct authorship
thorough review

Copilot

Pull request overview

This PR migrates 11 plumbing crates from thiserror to gix-error, implementing the project's error handling standardization strategy. The migration replaces enum-based error types with gix_error::Exn and uses message-based error construction for better composability and reduced boilerplate.

Changes:

Replaces thiserror enums with gix_error::Exn<gix_error::Message> or gix_error::ValidationError
Updates error construction to use message!() and raise() patterns
Adjusts downstream crates to handle new error types via .into_error() conversions
Replaces deprecated #[allow(missing_docs)] with #[expect(missing_docs)] throughout

Reviewed changes

Copilot reviewed 299 out of 349 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
gix-bitmap/src/ewah.rs	Converts EWAH decode error from thiserror enum to gix-error ValidationError
gix-quote/src/ansi_c.rs	Replaces ansi_c undo error enum with Exn
gix-mailmap/src/parse.rs	Converts mailmap parse errors to ValidationError
gix-fs/src/stack.rs	Updates path component error to ValidationError
gix-lock/src/acquire.rs	Migrates lock acquisition errors to Exn
gix-path/src/relative_path.rs	Converts RelativePath error to Exn
gix-path/src/realpath.rs	Replaces realpath error enum with Exn
gix-packetline/*	Converts encode/decode errors to gix-error types
gix-attributes/src/parse.rs	Migrates attribute parse errors to Exn
gix-url/src/expand_path.rs	Converts expand_path error to Exn
gix-hash/src/*	Replaces all hash-related errors with gix-error types
gix-features/src/zlib/*	Converts compression/decompression errors to Exn
gix/*	Updates downstream consumers to handle new error types

gix-url/tests/url/parse/file.rs

gix-hash/src/hasher.rs

gix-object/benches/edit_tree.rs

gix-packetline/tests/blocking-packetline.rs

gix/examples/clone.rs

This allows to more conveniently create validation errors.

Replace the thiserror-derived `ewah::decode::Error` enum with `gix_error::Exn<gix_error::ValidationError>`, using `ok_or_raise()` for Option-based error creation. Co-Authored-By: Sebastian Thiel <sebastian.thiel@icloud.com> Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>

Replace the thiserror-derived `ansi_c::undo::Error` enum with `gix_error::Exn<gix_error::ValidationError>`, converting the `Error::new()` factory and variant constructors to `message!()` calls. Co-Authored-By: Sebastian Thiel <sebastian.thiel@icloud.com> Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>

Replace the thiserror-derived `parse::Error` enum with `gix_error::Exn<gix_error::ValidationError>`. Tests converted from variant pattern matching to string-based assertions. Co-Authored-By: Sebastian Thiel <sebastian.thiel@icloud.com> Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>

Byron force-pushed the gix-error branch 2 times, most recently from 07cbdfc to 1632f78 Compare February 8, 2026 04:49

loci-dev mentioned this pull request Feb 8, 2026

UPSTREAM PR #2423: gix-error conversion batch 1 auroralabs-loci/gitoxide#20

Open

2 tasks

Byron mentioned this pull request Feb 8, 2026

Reorganise Error-Handling around Exn #2351

Open

72 tasks

Byron force-pushed the gix-error branch 16 times, most recently from 1427ae2 to bfaba3f Compare February 14, 2026 07:03

Byron mentioned this pull request Feb 15, 2026

Add GIX_TEST_FIXTURE_HASH to gix-testtools #2377

Merged

Byron force-pushed the gix-error branch 2 times, most recently from 8bb2abc to ec904dc Compare February 15, 2026 15:27

Byron requested a review from Copilot February 15, 2026 15:49

Copilot AI reviewed Feb 15, 2026

View reviewed changes

Byron force-pushed the gix-error branch from ec904dc to 87b38a5 Compare February 15, 2026 16:47

doc: add From<Message> for ValidationError guide.

fdf321b

This allows to more conveniently create validation errors.

Byron force-pushed the gix-error branch 3 times, most recently from 348f983 to 1cfb707 Compare February 18, 2026 03:36

Byron force-pushed the gix-error branch from 1cfb707 to 2d48c58 Compare February 18, 2026 03:49

Byron and others added 2 commits February 18, 2026 05:13

Byron marked this pull request as ready for review February 22, 2026 14:37

Byron merged commit 000d58a into main Feb 22, 2026
30 checks passed

Byron changed the title ~~gix-error conversion batch 1~~ gix-error conversion batch 1 (part 1) Feb 22, 2026

Byron mentioned this pull request Feb 22, 2026

gix-error conversion batch 1 (part 2) #2443

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gix-error conversion batch 1 (part 1)#2423

gix-error conversion batch 1 (part 1)#2423
Byron merged 4 commits intomainfrom
gix-error

Byron commented Feb 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Byron commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Crates done

Tasks

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Byron commented Feb 7, 2026 •

edited

Loading