fix gix-blame performance regresion#2154
Merged
Byron merged 1 commit intoGitoxideLabs:mainfrom Sep 6, 2025
Merged
Conversation
The issue was introduced in GitoxideLabs#1963, and incorrectly assumed that the `max-performance-safe` feature flag was only used to enable other feature flags. But this feature flag is itself used in various places, so failing to enable it leads to worse codegen. This issue was discussed/found in GitoxideLabs#2148
Contributor
|
I just ran the benchmark and can confirm that this fixes the performance regression on my linux/x86_64 machine! Thanks a lot! |
Byron
approved these changes
Sep 6, 2025
Member
Byron
left a comment
There was a problem hiding this comment.
Thanks SO much for figuring this out.
And I am so sorry I let that pass through the first time around.
In any case, I think digging into this also helped us gain something:
- zlib-rs, depending on the platform, can be slower when handling many small objects (even though
gixdoesn't notice this on MacOS at least). Now there is a test for that as a first step towards improving this. - zlib-rs can be used directly, and the
flate2dependency can be removed - I will see to bringing in your commit soon.
Member
|
And indeed, the natural order has been restored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2148
The issue was introduced in #1963, where it was incorrectly assumed that the
max-performance-safefeature flag was only used to enable other feature flags. But this feature flag is itself used in various places, so failing to enable it leads to worse codegen. This issue was discussed/found in #2148