Skip to content

#1515 - improve logic for findToolExecutable#1547

Merged
arturcic merged 1 commit intoGitTools:mainfrom
arturcic:fix/1515
Mar 29, 2025
Merged

#1515 - improve logic for findToolExecutable#1547
arturcic merged 1 commit intoGitTools:mainfrom
arturcic:fix/1515

Conversation

@arturcic
Copy link
Member

@arturcic arturcic commented Mar 29, 2025

This pull request includes significant enhancements to the DotnetTool class and its testing suite. The changes include the addition of a new method to find the tool executable, improvements to the executeTool method, and the creation of comprehensive unit tests.

Enhancements to DotnetTool class:

  • Added findToolExecutable method to locate the tool executable by checking the base path, architecture-specific paths, and subdirectories. This method handles different platforms and architectures.
  • Updated executeTool method to utilize the new findToolExecutable method, improving the robustness of locating the tool executable.

Unit tests for DotnetTool:

  • Created a new test suite in dotnet-tool.spec.ts to test the functionality of the DotnetTool class, including the findToolExecutable and disableTelemetry methods. This includes mocking dependencies and simulating different environments.

Closes #1515

@arturcic arturcic added this to the v3.x milestone Mar 29, 2025
@arturcic arturcic merged commit df7b5c8 into GitTools:main Mar 29, 2025
9 checks passed
@arturcic arturcic deleted the fix/1515 branch March 29, 2025 19:17
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2025

Thank you @arturcic for your contribution!

@arturcic arturcic removed this from the v3.x milestone Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ISSUE]: gitVersion execute task not immediately available after gitVersion setup task

1 participant