Skip to content

Rename back "tag-pre-release-weight" and "tag-prefix"#3481

Merged
arturcic merged 1 commit into
GitTools:mainfrom
ni-jsuchocki:feature/tag-and-label-name-separation
Apr 19, 2023
Merged

Rename back "tag-pre-release-weight" and "tag-prefix"#3481
arturcic merged 1 commit into
GitTools:mainfrom
ni-jsuchocki:feature/tag-and-label-name-separation

Conversation

@ni-jsuchocki

@ni-jsuchocki ni-jsuchocki commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

Description

Renamed
label-pre-release-weight => tag-pre-release-weight
label-prefix => tag-prefix

Related Issue

Fixes #3480

@arturcic arturcic requested review from arturcic and asbjornu April 17, 2023 14:39
@arturcic

Copy link
Copy Markdown
Member

@ni-jsuchocki please run these scripts ./build.ps1 -Stage build -Target BuildPrepare then the ./build.ps1 -Stage docs -Target GenerateSchemas to update the schemas

@ni-jsuchocki

Copy link
Copy Markdown
Contributor Author

Hmm I'm on Mac and I'm having hard time making the script work (managing various versions of dotnet on Mac is a mess). I have powershell installed and I ran the first command successfully, but when I run GenerateSchemas it tries to update a 5.11 schema for some reason (which doesn't exist in the repo):

Schema version: 5.11
Writing schema to .../GitVersion/schemas/5.11/GitVersion.configuration.json
Unhandled exception. System.IO.DirectoryNotFoundException: Could not find a part of the path '.../GitVersion/schemas/5.11/GitVersion.configuration.json'.

Any idea what causes this? The gitversion binary I have installed is 6.0.0:

gitversion /version
6.0.0-alpha.1+Branch.main.Sha.fc5b3ff045ea0e0f59c9bf27096af9094ca17f0e

@arturcic

Copy link
Copy Markdown
Member

GenerateSchemas gets its version by running the current gitversion from source code and not using the gitversion tool you have installed. For some reason running the gitversion against the gitversion source code you get 5.11 as the version. probably your fork does not have the tags for 5.12.0 and for 6.0.0 betas> Maybe you need to fetch them from the GitTools/GitVersion origin

@ni-jsuchocki

Copy link
Copy Markdown
Contributor Author

Ok thanks, that was it. For now I uploaded it as a separate commit, should I squash them before merging in the changes from main?

@arturcic

Copy link
Copy Markdown
Member

I would say squash them

@ni-jsuchocki ni-jsuchocki force-pushed the feature/tag-and-label-name-separation branch 2 times, most recently from d56fbd3 to 2796f0c Compare April 18, 2023 14:49
@arturcic

Copy link
Copy Markdown
Member

@ni-jsuchocki can you please rebase your changes on main ?

@ni-jsuchocki ni-jsuchocki force-pushed the feature/tag-and-label-name-separation branch from 2796f0c to 08a4b5c Compare April 19, 2023 10:03
Comment thread src/GitVersion.Core.Tests/IntegrationTests/VersionInTagScenarios.cs Outdated
Comment thread src/GitVersion.Core.Tests/IntegrationTests/VersionInTagScenarios.cs Outdated
@arturcic

Copy link
Copy Markdown
Member

@ni-jsuchocki can you check the comments?

@ni-jsuchocki

Copy link
Copy Markdown
Contributor Author

Sure sure, noticed that right after I rebased.

@ni-jsuchocki ni-jsuchocki force-pushed the feature/tag-and-label-name-separation branch from 08a4b5c to 921d024 Compare April 19, 2023 10:16
@arturcic arturcic merged commit d787beb into GitTools:main Apr 19, 2023
@mergify

mergify Bot commented Apr 19, 2023

Copy link
Copy Markdown
Contributor

Thank you @ni-jsuchocki for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Rename back to "tag-pre-release-weight" and "tag-prefix"

2 participants