Update GitReleaseNotes#1438
Merged
Merged
Conversation
arturcic
commented
Jul 3, 2018
Member
- Updated to latest version of GitReleaseNotes to fix the ssl issue when generating release notes
- fixed the version back to 4.0.0
Member
|
@arturcic thank you for taking the time to update this. Let's get this merged, and see if it helps with the error that was occurring. |
Member
|
@arturcic so, I don't "think" the failed build is unexpected, as I think it still expecting that the path to the releasenotes is present, which it isn't when the releasenotes are being created. I will try to take the current build for a spin later to see if I can get that part to work. Unless someone gets to it before me. |
Member
|
@arturcic looks like the build number is correctly working now, so thanks for making that change! |
Member
Author
|
I guess we just need to check if build folder exists and create it if not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.