Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 89.32% 87.75% -1.58%
==========================================
Files 3 3
Lines 909 931 +22
==========================================
+ Hits 812 817 +5
- Misses 97 114 +17
☔ View full report in Codecov by Sentry. |
- If ArpFile method succeeds, use it instead of arping. It's faster and less prone to breaking (for example, the current arpfile code breaks on the BusyBox version of arping)
- Support busybox's arping. It's basically iputils-arping, but every so slightly different enough to break getmac (: - Speed up the first call to ArpingHost by removing the command arg check. It now checks what variant is in use by just running the command as if it's iputils-arping/busybox arping, and if it fails in a certain way, then falls back to Habet's method. - Fix FORCE_METHOD not being respected for IPv4 macs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
arpingChanged
ArpFilemethod succeeds, use it instead ofArpingHost(this should fix #86, for realsies this time).ArpingHostThis should properly fix #86