Fix for Android 6.0.1#71
Conversation
Tested and working. Android 6.0.1 no need for root
|
Looks good. Would you mind capturing samples of the output so I can add them to the tests? Just copy-paste the output of the command and put it in a test file in ./tests/samples/ (also, apologies for the delay in responding to this) |
|
Done .. I added two files for two android commands. Just to let you know ... I am using your getmac with my changes in a small non-commercial project which is currently used by over 600 device worldwide .. and getmac proved to be a very good replacement of uuid .. i can confirm that getmac is producing a unique id of all these devices with no exceptions. Thank you. |
|
The 600 devices are mostly windows and android .. but i also have other operating systems using getmac perfactly. If you are interested to create a new uuid python module ... i can send you my script that convert the mac address to an id that consist of 16 digits (numbers) .. plus the new id have an extra 4 digits that works similar to checksum for verifying this new id is not manipulated in any way. |
I think you might've forgotten to push the changes. |
Wow that's awesome! Thank you so much for sharing that, I love hearing how it gets used and that it helps people out 😁 |
|
I am using github web .. I did not find a way to push my commits to your code ... I think you have to pull these changes and merge them with your code .. I have two pulls (branches) that needs to be merged to your code "patch-1" and "patch-2" |
|
May open the second branch as a new PR? Unfortunately I don't use GitHub web much. |
|
I think you forgot to merege "patch-2" .. it contains the two samples files .. while "patch-1" which already merged contains the modification of "getmac.py" file |
|
The only PR I see is this one for |
Tested and working.
Android 6.0.1
no need for root
All Submissions:
Code changes:
black getmac teststox -e checktoxSummary of changes: