Skip to content

Adds support for docker in network bridge mode.#57

Merged
GhostofGoes merged 1 commit intoGhostofGoes:masterfrom
tomaszduda23:master
Apr 18, 2020
Merged

Adds support for docker in network bridge mode.#57
GhostofGoes merged 1 commit intoGhostofGoes:masterfrom
tomaszduda23:master

Conversation

@tomaszduda23
Copy link
Contributor

@tomaszduda23 tomaszduda23 commented Mar 29, 2020

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

Code changes:

  • Did you format your code with Black?
    • black getmac tests
  • Are the linting checks passing?
    • tox -e check
  • Do all tests pass locally?
    • tox
  • Have you updated the CHANGELOG with a summary of your change?
  • Did you add your name to the contributors list in the README?

Summary of changes:

@GhostofGoes
Copy link
Owner

Please complete the last two steps in the checklist: update the CHANGELOG and add your name to the list of contributors in the README.

Copy link
Owner

@GhostofGoes GhostofGoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Apologies for the delay!

@GhostofGoes GhostofGoes merged commit ce45736 into GhostofGoes:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants