Skip to content

Support Thomas Habets' arping#54

Merged
GhostofGoes merged 1 commit intoGhostofGoes:masterfrom
scop:arping-habets
Dec 31, 2019
Merged

Support Thomas Habets' arping#54
GhostofGoes merged 1 commit intoGhostofGoes:masterfrom
scop:arping-habets

Conversation

@scop
Copy link
Contributor

@scop scop commented Dec 21, 2019 •
edited
Loading

Refs ThomasHabets/arping#37

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

Code changes:

  • Did you format your code with Black?
    • black getmac tests
  • Are the linting checks passing?
    • tox -e check
  • Do all tests pass locally?
    • tox
  • Have you updated the CHANGELOG with a summary of your change?
  • Did you add your name to the contributors list in the README?

Summary of changes:

@GhostofGoes
Copy link
Owner

GhostofGoes commented Dec 31, 2019

How common is this variant of arping and what distros include it in their package repositories?

@GhostofGoes GhostofGoes merged commit 0b60607 into GhostofGoes:master Dec 31, 2019
@scop scop deleted the arping-habets branch December 31, 2019 06:19
@scop
Copy link
Contributor Author

scop commented Dec 31, 2019

I don't know the full details. For Debian, it is what one gets when installing arping by package name, but it's significantly less common than the iputils one per popcon.
https://qa.debian.org/popcon.php?package=arping
https://qa.debian.org/popcon.php?package=iputils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scop @GhostofGoes