You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Code changes:
Did you format your code with Black?
black getmac tests
Are the linting checks passing?
tox -e check -- no, but they weren't passing before this change either:
check run-test: commands[3] | flake8 getmac tests setup.py
getmac/getmac.py:1:1: T499 Success: no issues found in 1 source file
# -*- coding: utf-8 -*-
^
ERROR: InvocationError for command [...]/getmac/.tox/check/bin/flake8 getmac tests setup.py (exited with code 1)
Do all tests pass locally?
tox
Have you updated the CHANGELOG with a summary of your change?
Did you add your name to the contributors list in the README?
Summary of changes:
When other things have yielded no results, try arping. Depending on system, it may require an interface to be specified and fail without one, but would improve things where it doesn't.
Thanks! Turns out it doesn't immediately seem to fix the problem, but I believe it's a good addition to have in getmac anyway.
Alas, I've learned that the https://github.com/ThomasHabets/arping arping implementation doesn't support the -f option, and its output differs from the iputils/busybox arping somewhat as well. So for now this implementation doesn't work with the ThomasHabets one -- I'll see if I can get the -f option supported there too, as well as submit a followup PR here to recognize its output. (The -f could in theory be dropped, but it makes the call a bit faster, so I think it's good to keep it.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Code changes:
black getmac teststox -e check-- no, but they weren't passing before this change either:toxSummary of changes:
When other things have yielded no results, try arping. Depending on system, it may require an interface to be specified and fail without one, but would improve things where it doesn't.