Skip to content

Conversation

@shahzadansari
Copy link
Contributor

There is no mapped emoji available for :hate: in ReactionMapper. so the emoji fallbacks to text only.

🎯 Goal

Before

Screenshot 2024-03-17 at 4 49 51 PM

After

Screenshot 2024-03-17 at 4 49 46 PM

🛠 Implementation details

Replaced ":hate:" usage with ":dislike:" as it is available in ReactionMapper

fun defaultReactionMapper(): ReactionMapper {
            return ReactionMapper { emojiCode ->
                when (emojiCode) {
                    ":fireworks:", ":tada:" -> "\uD83C\uDF89"
                    ":raise-hand:" -> "✋"
                    ":like:" -> "\uD83D\uDC4D"
                    ":dislike:" -> "\uD83D\uDC4E"
                    ":hello:" -> "\uD83D\uDC4B"
                    ":smile:" -> "\uD83D\uDE42"
                    ":heart:" -> "\u2665"
                    else -> emojiCode
                }
            }
        }

There is no mapped emoji available for "hate" in ReactionMapper.kt so the emoji fallbacks to text only
@shahzadansari shahzadansari requested a review from skydoves as a code owner March 17, 2024 11:55
Copy link
Contributor

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for your contribution, @shahzadansari !

@skydoves skydoves merged commit 5788d90 into GetStream:main Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants