Remove TopBar dependency on ViewModel #193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fix "MessageTopBar Preview is broken" issue #192
🛠 Implementation details
@Composable WhatsAppMessageTopBartakesWhatsAppMessagesViewModelas a parameter and since we cannot instantiate ViewModel in Previews, it doesn't render the Preview.Before
After
✍️ Explain examples
Setup a callback to trigger a function in ViewModel instead (takes
videoCallflag as a param to be passed onto VM).