Skip to content

Use SDK size workflows from build conventions repository #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gpunto merged 1 commit into from
Dec 25, 2025
Merged

Use SDK size workflows from build conventions repository #1590

gpunto merged 1 commit into from
Dec 25, 2025

Conversation

@gpunto
Copy link
Contributor

@gpunto gpunto commented Dec 24, 2025 •
edited by coderabbitai bot
Loading

Goal

SDK size workflows were also moved to the build conventions repo, so we're pointing to them now. Also bumping to 0.6.1 instead of 0.6.0 as the former has a fix for one of these workflows.

Implementation

Use new coordinate

🎨 UI Changes

None

Testing

The workflows should run correctly. The size update one will be tested on merge

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (required internally)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)
  • Tutorial starter kit updated
  • Examples/guides starter kits updated (stream-video-examples)

☑️Reviewer Checklist

  • XML sample runs & works
  • Compose sample runs & works
  • Tutorial starter kit
  • Example starter kits work
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs
  • Check the SDK Size Comparison table in the CI logs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

Summary by CodeRabbit

  • Chores
    • Updated continuous integration infrastructure configuration to use the latest versions of shared build utilities and conventions, enhancing compatibility and consistency across automated Android build processes, SDK metrics verification, and repository maintenance operations. These updates maintain development workflow stability without affecting user-facing functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@gpunto gpunto added the pr:ci CI / GitHub Actions / workflow updates label Dec 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025 •
edited
Loading

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.94 MB 11.94 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.27 MB 6.27 MB 0.00 MB 🟢

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gpunto gpunto marked this pull request as ready for review December 24, 2025 10:53
@gpunto gpunto requested a review from a team as a code owner December 24, 2025 10:53
@coderabbitai
Copy link

coderabbitai bot commented Dec 24, 2025 •
edited
Loading

Walkthrough

This PR updates GitHub Actions workflow references across multiple CI configuration files, upgrading versions from v0.6.0 to v0.6.1 and migrating some workflows from the android-ci-actions repository to the stream-build-conventions-android repository.

Changes

Cohort / File(s) Summary
Version bump to v0.6.1
.github/workflows/android.yml, .github/workflows/pr-clean-old-drafts.yaml, .github/workflows/pr-quality.yml		 Updated shared workflow references from v0.6.0 to v0.6.1 without altering control flow or configuration logic.
Repository migration to stream-build-conventions-android
.github/workflows/sdk-size-checks.yml, .github/workflows/sdk-size-updates.yml		 Migrated workflow sources from GetStream/android-ci-actions@main to GetStream/stream-build-conventions-android@v0.6.1 with inputs unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • aleksandar-apostolov

Poem

🐰 Workflows hop to a newer release,
From v0.6.0 to v0.6.1 with ease,
Conventions consolidated, repos aligned,
CI pipelines streamlined by design! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating SDK size workflows to reference the build conventions repository instead of the previous source.
Description check ✅ Passed The description includes Goal, Implementation, UI Changes, and Testing sections with relevant details. While some contributor/reviewer checklist items are unchecked, the description covers the essential information about the PR's purpose and approach.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch and-961/move-workflows-2
📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 01b3abc and 29aeff2.

📒 Files selected for processing (5)
  • .github/workflows/android.yml
  • .github/workflows/pr-clean-old-drafts.yaml
  • .github/workflows/pr-quality.yml
  • .github/workflows/sdk-size-checks.yml
  • .github/workflows/sdk-size-updates.yml
🔇 Additional comments (5)
.github/workflows/pr-clean-old-drafts.yaml (1)

16-16: LGTM! Version bump is consistent with PR objectives.

The update to v0.6.1 aligns with the PR-wide version bump. The workflow reference and configuration remain otherwise unchanged.

.github/workflows/pr-quality.yml (1)

18-18: LGTM! Version bump is consistent with PR objectives.

The update to v0.6.1 aligns with the coordinated version bump across all workflows in this PR.

.github/workflows/android.yml (1)

21-21: LGTM! Version bump is consistent with PR objectives.

The update to v0.6.1 maintains consistency with the coordinated version bump across the project's CI workflows.

.github/workflows/sdk-size-updates.yml (1)

16-16: LGTM! Workflow migration is properly pinned and verified.

The migration from android-ci-actions to stream-build-conventions-android at v0.6.1 is consistent with the PR's goal of consolidating SDK size workflows. The v0.6.1 tag exists and the sdk-size-updates.yml workflow is present with a compatible interface, accepting the required metrics-project and modules inputs. Version pinning provides better stability than using @main.

.github/workflows/sdk-size-checks.yml (1)

12-12: Target repository GetStream/stream-build-conventions-android cannot be publicly verified.

The workflow references GetStream/stream-build-conventions-android@v0.6.1, but web search cannot locate this repository on GitHub. Public GetStream Android repositories include stream-video-android, stream-feeds-android, and others, but not stream-build-conventions-android. Verify that this is the correct repository name and that it contains the referenced workflow at v0.6.1, or confirm it is a private repository with access before approving this migration.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gpunto gpunto enabled auto-merge (squash) December 24, 2025 13:29
@gpunto
Copy link
Contributor Author

gpunto commented Dec 24, 2025

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Dec 24, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@gpunto gpunto merged commit b9c9ceb into develop Dec 25, 2025
14 checks passed
@gpunto gpunto deleted the and-961/move-workflows-2 branch December 25, 2025 09:34
@coderabbitai coderabbitai bot mentioned this pull request Jan 5, 2026
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandar-apostolov aleksandar-apostolov aleksandar-apostolov approved these changes

Assignees

No one assigned

Labels

pr:ci CI / GitHub Actions / workflow updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gpunto @aleksandar-apostolov