Skip to content

Conversation

@aleksandar-apostolov
Copy link
Contributor

Goal

Vibrations will not actuate if the phone is set to silent.

Implementation

Check AudioManager state to see if we are allowed to vibrate.

Testing

Run ringing calls in different phone modes. In silent (DND etc..) there should be no vibration.

@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner October 27, 2025 10:13
@aleksandar-apostolov aleksandar-apostolov added the pr:improvement Enhances an existing feature or code label Oct 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

Copy link
Contributor

@rahul-lohra rahul-lohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.74 MB 11.74 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.27 MB 6.27 MB 0.00 MB 🟢

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@aleksandar-apostolov aleksandar-apostolov merged commit de6825b into develop Oct 28, 2025
11 of 12 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the phone-based-vibrate branch October 28, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:improvement Enhances an existing feature or code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants