Skip to content

Add the possibility to vibrate during an incoming call. #1550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aleksandar-apostolov merged 14 commits into from
Oct 21, 2025
Merged

Add the possibility to vibrate during an incoming call. #1550

aleksandar-apostolov merged 14 commits into from
Oct 21, 2025

Conversation

@aleksandar-apostolov
Copy link
Contributor

@aleksandar-apostolov aleksandar-apostolov commented Oct 20, 2025 •
edited
Loading

Goal

AND-861

Add the possibility to vibrate during an incomming call.

Implementation

CallSoundPlayer - > Renamed to CallSoundAndVibrationPlayer.
Added vibrate() and stopVibration() methods.
Using internal android.os.Vibrator to do a repeatable vibration pattern.

Added a config parameter on the StreamVideoBuilder. By default the configuration allows setting a pattern and on/off flag as in enabled:Boolean.
By default the vibrations are disabled as this is the current behaviour.

Added three utility methods for ready to use configurations.

Testing

Vibrations are enabled in demo-app, run the demo app and make a ringing call.

@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner October 20, 2025 14:36
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025 •
edited
Loading

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@aleksandar-apostolov aleksandar-apostolov changed the title vibrate [AND-861] Add the possibility to vibrate during an incoming call. Oct 20, 2025
@aleksandar-apostolov aleksandar-apostolov added the pr:new-feature Adds new functionality label Oct 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.73 MB 11.73 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.70 MB 5.70 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.25 MB 6.25 MB 0.00 MB 🟢

@aleksandar-apostolov aleksandar-apostolov changed the title [AND-861] Add the possibility to vibrate during an incoming call. Add the possibility to vibrate during an incoming call. Oct 20, 2025
rahul-lohra
rahul-lohra approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@rahul-lohra rahul-lohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 21, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
19.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@aleksandar-apostolov aleksandar-apostolov merged commit 66d2263 into develop Oct 21, 2025
24 of 29 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the vibrate branch October 21, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahul-lohra rahul-lohra rahul-lohra approved these changes

Assignees

No one assigned

Labels

pr:new-feature Adds new functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aleksandar-apostolov @rahul-lohra