Skip to content

Conversation

@rahul-lohra
Copy link
Contributor

@rahul-lohra rahul-lohra commented Oct 10, 2025

Goal

Ensure the microphone remain active when the app goes to the background by preventing the call-related services from being marked as short-lived.

Implementation

  1. Correctly use service type as ServiceInfo.FOREGROUND_SERVICE_TYPE_PHONE_CALL or ServiceInfo.FOREGROUND_SERVICE_TYPE_CAMERA or ServiceInfo.FOREGROUND_SERVICE_TYPE_MICROPHONE for video/audio cal types

Testing

Smoke test audio/video call, put the application on background or turn off the screen

@rahul-lohra rahul-lohra requested a review from a team as a code owner October 10, 2025 13:09
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@rahul-lohra rahul-lohra changed the title Ensure the microphone remain active when the app goes to the background Ensure microphone stays active during backgrounded audio/video calls Oct 10, 2025
@rahul-lohra rahul-lohra self-assigned this Oct 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.73 MB 11.73 MB 0.00 MB 🟢
stream-video-android-ui-xml 5.70 MB 5.70 MB 0.00 MB 🟢
stream-video-android-ui-compose 5.86 MB 5.86 MB 0.00 MB 🟢

@aleksandar-apostolov
Copy link
Contributor

Did you test with not having the record permission when joining a call? So you have to accept the permission first and then update the service type. That is why we had short service.

@rahul-lohra rahul-lohra added the pr:improvement Enhances an existing feature or code label Oct 10, 2025
@rahul-lohra rahul-lohra changed the title Ensure microphone stays active during backgrounded audio/video calls [AND-284] Ensure microphone stays active during backgrounded audio/video calls Oct 13, 2025
@rahul-lohra rahul-lohra changed the title [AND-284] Ensure microphone stays active during backgrounded audio/video calls Ensure microphone stays active during backgrounded audio/video calls Oct 13, 2025
@rahul-lohra rahul-lohra changed the title Ensure microphone stays active during backgrounded audio/video calls [AND-824] Ensure microphone stays active during backgrounded audio/video calls Oct 13, 2025
@rahul-lohra rahul-lohra changed the title [AND-824] Ensure microphone stays active during backgrounded audio/video calls Ensure microphone stays active during backgrounded audio/video calls Oct 13, 2025
@rahul-lohra rahul-lohra changed the title Ensure microphone stays active during backgrounded audio/video calls [AND-823] Ensure microphone stays active during backgrounded audio/video calls Oct 13, 2025
@rahul-lohra rahul-lohra changed the title [AND-823] Ensure microphone stays active during backgrounded audio/video calls Ensure microphone stays active during backgrounded audio/video calls Oct 13, 2025
@rahul-lohra rahul-lohra marked this pull request as draft October 14, 2025 06:44
@rahul-lohra rahul-lohra marked this pull request as ready for review October 14, 2025 13:34
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
65.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@aleksandar-apostolov aleksandar-apostolov merged commit 08ece0c into develop Oct 16, 2025
15 of 17 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the bugfix/rahullohra/background-mic branch October 16, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:improvement Enhances an existing feature or code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants