Skip to content

Support runtime audio usage resolution #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aleksandar-apostolov merged 5 commits into from
Oct 22, 2025
Merged

Support runtime audio usage resolution #1544

aleksandar-apostolov merged 5 commits into from
Oct 22, 2025

Conversation

@rahul-lohra
Copy link
Contributor

@rahul-lohra rahul-lohra commented Oct 9, 2025 •
edited
Loading

Goal

Deprecate the fixed audioUsage: Int parameter and replace it with a lambda-based provider. This allows audio usage to be resolved dynamically at invocation time rather than being fixed during construction.

Implementation

  • Added a new constructor parameter audioUsageProvider: () -> Int with default { defaultAudioUsage }.
  • Deprecated the existing audioUsage: Int parameter with a ReplaceWith hint to guide migration.
  • Updated internal references to resolve audio usage by invoking the provider.

Testing

Smoke test livestream tutorial

@rahul-lohra rahul-lohra self-assigned this Oct 9, 2025
@rahul-lohra rahul-lohra added the pr:improvement Enhances an existing feature or code label Oct 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025 •
edited
Loading

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 11.73 MB 11.74 MB 0.02 MB 🟢
stream-video-android-ui-xml 5.70 MB 5.68 MB -0.02 MB 🚀
stream-video-android-ui-compose 6.25 MB 6.25 MB 0.00 MB 🟢

@rahul-lohra rahul-lohra changed the title Replace audioUsage with audioUsageProvider [AND-785] Replace audioUsage with audioUsageProvider Oct 10, 2025
@rahul-lohra rahul-lohra changed the title [AND-785] Replace audioUsage with audioUsageProvider Replace audioUsage with audioUsageProvider Oct 10, 2025
@rahul-lohra rahul-lohra reopened this Oct 22, 2025
@rahul-lohra rahul-lohra changed the title Replace audioUsage with audioUsageProvider Support dynamic audio usage resolution Oct 22, 2025
@rahul-lohra rahul-lohra changed the title Support dynamic audio usage resolution Support runtime audio usage resolution Oct 22, 2025
@rahul-lohra rahul-lohra marked this pull request as ready for review October 22, 2025 04:30
@rahul-lohra rahul-lohra requested a review from a team as a code owner October 22, 2025 04:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 22, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@aleksandar-apostolov aleksandar-apostolov merged commit 9d73087 into develop Oct 22, 2025
11 of 12 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the chore/rahullohra/dynmic-call-config-usage branch October 22, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandar-apostolov aleksandar-apostolov aleksandar-apostolov approved these changes

Assignees

@rahul-lohra rahul-lohra

Labels

pr:improvement Enhances an existing feature or code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rahul-lohra @aleksandar-apostolov