Upgrade to webrtc m137 and remove stream-webrtc-android-ui dep #1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age for unused participants
2. No need to copy the Map everytime as updates to concurrent map can be made in thread safe way 3. Keep an internal mutable map and use a shallow copy of Hashmap for emitting externally - reduces unce
… guarantee that all webrtc calls are executed from the same thread in a serial manner.
…nto fix-memory-issues
- Removed dependency of stream.webrtc.ui
…nto upgrade-webrtc-m137 # Conflicts: # gradle/libs.versions.toml # stream-video-android-core/api/stream-video-android-core.api # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/RtcSession.kt # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/connection/Publisher.kt # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/utils/SerialProcessor.kt
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
…nto upgrade-webrtc-m137
Contributor
SDK Size Comparison 📏
|
Remove scalability mode checks in Publisher.kt Make VideoCodecScalabilityChecker internal
rahul-lohra
reviewed
Oct 10, 2025
Contributor
rahul-lohra
left a comment
There was a problem hiding this comment.
Please check my comments on breaking change.
...id-core/src/main/kotlin/io/getstream/video/android/core/renderer/VideoTextureViewRenderer.kt
Outdated
Show resolved
Hide resolved
aleksandar-apostolov
approved these changes
Oct 10, 2025
…here is no breaking changes in the public api
testableapple
approved these changes
Oct 13, 2025
|
aleksandar-apostolov
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To upgrade to m137 version of webrtc and remove stream-webrtc-android-ui dependancy
Implementation
Compiled from the m137 head of webrtc along with other patches
Removed depedancy on webrtc-android-ui
Moved
VideoTextureViewRendererto coreTesting
Install and test all features related to webrtc