Skip to content

Conversation

@VelikovPetar
Copy link
Contributor

🎯 Goal

We currently don't support delivery receipts in threads. Adds a guard preventing thread replies to be marked as delivered (except those sent in channel as well).

🛠 Implementation details

Add guard preventing thread replies to be marked as delivered (except those sent in channel as well).

🎨 UI Changes

NA

🧪 Testing

  1. User 1: Send thread reply to a message from User 2
  2. User 2: Observe the logs with tag: [canMarkMessageAsDelivered]
  3. Thread replies should be rejected
  4. Thread replies also sent to channel should NOT be rejected

@VelikovPetar VelikovPetar marked this pull request as ready for review November 19, 2025 11:33
@VelikovPetar VelikovPetar requested a review from a team as a code owner November 19, 2025 11:33
@github-actions
Copy link
Contributor

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 5.25 MB 5.25 MB 0.00 MB 🟢
stream-chat-android-offline 5.47 MB 5.47 MB 0.00 MB 🟢
stream-chat-android-ui-components 10.58 MB 10.58 MB 0.00 MB 🟢
stream-chat-android-compose 12.81 MB 12.81 MB 0.00 MB 🟢

@sonarqubecloud
Copy link

@VelikovPetar VelikovPetar merged commit ce62a9f into develop Nov 19, 2025
13 checks passed
@VelikovPetar VelikovPetar deleted the bug/AND-910_prevent_marking_thread_replies_as_delivered branch November 19, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants