#2057: Fix - MS widgets cannot retrieve data when connected to an attribute table#2125
#2057: Fix - MS widgets cannot retrieve data when connected to an attribute table#2125giohappy merged 1 commit intoGeoNode:4.4.xfrom
Conversation
… an attribute table
There was a problem hiding this comment.
Summary of Changes
Hello @dsuren1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to resolve a data retrieval issue affecting MapStore widgets when they are linked to an attribute table. The solution involves updating a core submodule to a version that includes the required bug fix, ensuring proper data flow for these widgets.
Highlights
- Bug Fix: This pull request addresses a critical bug where MapStore (MS) widgets were unable to retrieve data when connected to an attribute table.
- Submodule Update: The fix is implemented by updating the
MapStore2Git submodule to a newer commit (7544f6593fb41a7e9b9222cbfdcd3b3aa39310c0), which incorporates the necessary patch from the MS stable branch2024.02.xx.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the MapStore2 submodule to a newer commit, which, according to the description, incorporates a bug fix. The change itself is a standard submodule pointer update. My review includes a recommendation to enhance the pull request's documentation by linking to the specific changes within the submodule. This practice significantly improves transparency and maintainability for such dependency updates.
Description
This PR updates MS submodule to include fix made in MS stable branch 2024.02.xx