Skip to content

Testcases: Added testcases for WorldCountries Component#700

Merged
BilelJegham merged 5 commits intoGeoGuess:masterfrom
NitinRamnani:WorldCountries-testcases
Oct 2, 2023
Merged

Testcases: Added testcases for WorldCountries Component#700
BilelJegham merged 5 commits intoGeoGuess:masterfrom
NitinRamnani:WorldCountries-testcases

Conversation

@NitinRamnani
Copy link
Copy Markdown
Contributor

@NitinRamnani NitinRamnani commented Sep 30, 2023 •
edited
Loading

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

Testcases: Added testcases for WorldCountries Component and improved code coverage

How Has This Been Tested?

Screenshots (if appropriate):

image

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 30, 2023 •
edited
Loading

‼️ Deploy request for geoguess2 rejected.

Name Link
🔨 Latest commit 3609dbd

BilelJegham
BilelJegham reviewed Oct 1, 2023
View reviewed changes
BilelJegham
BilelJegham requested changes Oct 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@BilelJegham BilelJegham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fail, and a small feedback

Thank for your contribution

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4c5aa3d) 51.86% compared to head (3609dbd) 52.12%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
+ Coverage   51.86%   52.12%   +0.26%     
==========================================
  Files          53       53              
  Lines         752      752              
  Branches      209      209              
==========================================
+ Hits          390      392       +2     
+ Misses        330      328       -2     
  Partials       32       32

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NitinRamnani
Copy link
Copy Markdown
Contributor Author

NitinRamnani commented Oct 2, 2023

Fixed issue that was failing CI.

@BilelJegham
Copy link
Copy Markdown
Member

BilelJegham commented Oct 2, 2023

@all-contributors please @NitinRamnani for test

@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors bot commented Oct 2, 2023

@BilelJegham

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@BilelJegham
Copy link
Copy Markdown
Member

BilelJegham commented Oct 2, 2023

@all-contributors please add @NitinRamnani for test

@allcontributors allcontributors bot mentioned this pull request Oct 2, 2023
Merged
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors bot commented Oct 2, 2023

@BilelJegham

I've put up a pull request to add @NitinRamnani! 🎉

@BilelJegham BilelJegham merged commit 4a1b827 into GeoGuess:master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BilelJegham BilelJegham Awaiting requested review from BilelJegham

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NitinRamnani @BilelJegham