[FEAT] In-game Scoreboard/Leaderboard#579
Conversation
👷 Deploy request for geoguess2 pending review.Visit the deploys page to approve it
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Works very well, should merge this |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hello, Really sorry... totally forgot to check the pr. Code seems good for me. :) I have to same UX suggestion:
|
|
I've hidden the leaderboard options in singleplayer, and additionally moved the leaderboard when the full screen map appears at the end of the round, I think this looks better than just increasing the z-index since it would overlap the edges of the map. |
|
Looks pretty good |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 51.28% 51.60% +0.32%
==========================================
Files 52 53 +1
Lines 741 746 +5
Branches 205 209 +4
==========================================
+ Hits 380 385 +5
Misses 329 329
Partials 32 32
☔ View full report in Codecov by Sentry. |
|
@all-contributors please add @Troplo for code |
|
@Troplo already contributed before to code I've put up a pull request to add @ElectricS01! 🎉 |
Types of Changes
Description
Closes #127, adds an in-game scoreboard on the top right hand corner of the screen which can be configured to either display both the user's score, and whether they have guessed, just guess status, or disable it completely on the game settings screen.
On mobile a little button is added next to the game duration which opens up a dialog to view the leaderboard.
How Has This Been Tested?
All tests pass, and is currently deployed on my instance along with my other changes from PR #572
Screenshots (if appropriate):