Skip to content

Slightly Better TimePicker#486

Merged
BilelJegham merged 3 commits intoGeoGuess:masterfrom
EliteAsian123:master
Jun 30, 2022
Merged

Slightly Better TimePicker#486
BilelJegham merged 3 commits intoGeoGuess:masterfrom
EliteAsian123:master

Conversation

@EliteAsian123
Copy link
Copy Markdown
Contributor

@EliteAsian123 EliteAsian123 commented Jun 27, 2022 •
edited by BilelJegham
Loading

## Types of Changes

- [ ] Bug fix (non-breaking change that fixes an issue)
- [x] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes

  • Bug fix: Added padding to the seconds so it displays 00 instead of just 0
  • Adjustment: The time updates while the slider is being moved instead of after it has moved
  • Adjustment: Slider ticks

Screenshots (if appropriate):

Before:

Before

After:

After

@netlify
Copy link
Copy Markdown

netlify bot commented Jun 27, 2022 •
edited
Loading

‼️ Deploy request for geoguess2 rejected.

Name Link
🔨 Latest commit 31cd3c3

BilelJegham
BilelJegham requested changes Jun 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@BilelJegham BilelJegham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for you contribution.

I write a small feedback.

Best regards,
Bilel

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 29, 2022 •
edited
Loading

Codecov Report

Merging #486 (3a8b6b6) into master (34aec64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #486   +/-   ##
=======================================
  Coverage   55.81%   55.81%           
=======================================
  Files          46       46           
  Lines         774      774           
  Branches      158      158           
=======================================
  Hits          432      432           
  Misses        310      310           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34aec64...3a8b6b6. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

BilelJegham
BilelJegham approved these changes Jun 30, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@BilelJegham BilelJegham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

Thanks @EliteAsian123

@BilelJegham BilelJegham merged commit 71b12f7 into GeoGuess:master Jun 30, 2022
@BilelJegham
Copy link
Copy Markdown
Member

BilelJegham commented Jun 30, 2022

@all-contributors please add @EliteAsian123 for code

@allcontributors allcontributors bot mentioned this pull request Jun 30, 2022
Merged
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors bot commented Jun 30, 2022

@BilelJegham

I've put up a pull request to add @EliteAsian123! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BilelJegham BilelJegham BilelJegham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EliteAsian123 @BilelJegham