Codecov Report

Merging #102 (6ea0d9f) into master (59a1f5d) will decrease coverage by 0.40%.
The diff coverage is 17.94%.

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   26.37%   25.96%   -0.41%     
==========================================
  Files          26       28       +2     
  Lines         872      905      +33     
  Branches      153      160       +7     
==========================================
+ Hits          230      235       +5     
- Misses        642      668      +26     
- Partials        0        2       +2     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59a1f5d...6ea0d9f. Read the comment docs.

Test summary

3 • 0 • 0 • 0

Run details

Project	Geoguess
Status	Passed
Commit	fb9226c ℹ️
Started	Feb 8, 2021 7:21 PM
Ended	Feb 8, 2021 7:23 PM
Duration	01:39 💡
OS	Linux Ubuntu - 16.04
Browser	Chrome 88

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

This is a large PR! I like to see it. Thank you very much! I tested it locally. It looks very nice! Geoguess is now playable on mobile devices like tablets and smartphones! I love this! Nevertheless, I would like to share points that I have noticed:

NPM Vulnerabilties

NPM audit reports, that some vulnerabilities require our attention. One of them seems risky. NPM-Advisory-Codes are 1548, 1426, 1179, 1500, and 1523. I think, they just want to update us some libraries ;). After testing this PR we should look at this, before creating a new release.

Unfortunately, I'm in the exam period and don't have time to look at it in detail. Maybe later!

Small Design Issues

The mobile design for Chromium-Browsers is working well! Unfortunately, other browsers like firefox still having design issues. So the map does not open on smartphone-view. On a tablet, I am unable to click on "guess", it is setting the marker under the guess-button onto the map. Nevertheless, it is a huge step forward!

EDIT: On chromium-smartphone-view the size of the map can be higher, after clicking on the "expand"-button.

Best regards and thank you very much!

Thanks a lot @wlanowski
I check npm vulnerabilities.

For design issue :
Can you specify devices selected with firefox ? (width/ height/ version ,...)

If you can add, screenshots it will be perfect. 🤩

For design issue :
Can you specify devices selected with firefox ? (width/ height/ version ,...)

If you can add, screenshots it will be perfect. 🤩

See #104