Update CLI to the v2 of System.CommandLine #174
Merged
VJalili merged 32 commits intoGenometric:devfrom Oct 15, 2022
Merged
Conversation
…r parsing args and asserting inputs; and refactor Orchestrate to Invoke.
…instead of Main which is static and its state is shared across different runs.
Codecov Report
@@ Coverage Diff @@
## dev #174 +/- ##
==========================================
- Coverage 97.41% 97.03% -0.39%
==========================================
Files 43 43
Lines 2091 2091
==========================================
- Hits 2037 2029 -8
- Misses 10 13 +3
- Partials 44 49 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ssues when combined with custom parsers.
…w cli. Disable some tests on the warnings, as the new cli does not show warnings.
# The temp dir returned by GetTempPath may not be accessible on github actions.
… to challenges in system.commandline with exit code propogation when exception occur.
…licting console information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the command line interface, by replacing the deprecated underlying library,
"Microsoft.Extensions.CommandLineUtils", with its successor, the current latest version ofSystem.CommandLine.System.CommandLineis currently in the preview mode and its API may change, hence the logic implemented in this PR may also need to be updated.This PR tries to keep changes to the user-facing interface at the minimum possible, only making the required improvements or dropping features currently not supported by
System.CommandLine. All the arguments remain unchanged (with the exception of one), but the help page is improved.Interface change
--folderargument because--inputcan be used to get the same functionality.Known issues
Postponed improvements
Option<T>s.