Improvements to the benchmarking script#172
Merged
VJalili merged 3 commits intoGenometric:devfrom Oct 5, 2022
Merged
Conversation
…ould be localized. # Temp seems not to be portable. It fails on mac with access-related issue and running with sudo does not fix it either.
Codecov Report
@@ Coverage Diff @@
## dev #172 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 43 43
Lines 2091 2091
=======================================
Hits 2037 2037
Misses 10 10
Partials 44 44 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sudomay not also fix it. Hence, switch to using the current execution dir instead of the system/user temp dir.