Add test file for draft pull requests#869
Closed
willschlitzer wants to merge 2 commits intomasterfrom
Closed
Conversation
Contributor
Author
Member
I can't say I like this. |
Contributor
Author
Would you recommend something differently, or not reducing the tests at all for drafts? My thought is that ubuntu typically runs the fastest, and this will provide a check on all the tests without requiring so many CI jobs for ever minor change, but still running the gamut of tests when the PR is marked ready for review. |
Member
|
@willschlitzer See #906 for the better implementation and don't forget to push the "Delete branch" button if you no longer need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #584, this is a change of the .yaml files to create a test for draft pull requests. In a draft, the tests only run Python 3.9 on Ubuntu-latest. The entire test suite for different operating systems and Python versions only runs when the pull request is marked ready for review.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version