Add the shading parameter to colorbar() in base_plotting.py#752
Merged
seisman merged 17 commits intoGenericMappingTools:masterfrom Dec 22, 2020
Merged
Add the shading parameter to colorbar() in base_plotting.py#752seisman merged 17 commits intoGenericMappingTools:masterfrom
seisman merged 17 commits intoGenericMappingTools:masterfrom
Conversation
Member
Contributor
Author
|
Didn't think to check the GMT docs on this one; copied the text from the GMT docs and changed the arguments to string or boolean |
Member
|
Hi @willschlitzer more work needs to be done here. So the possible values of the
For case 3, it would be better if we can also support |
Member
To implement the feature, you need to add |
Contributor
Author
|
Sounds good, I'll work on this tomorrow |
seisman
reviewed
Dec 22, 2020
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Dec 22, 2020
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Dec 22, 2020
seisman
approved these changes
Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #749, this adds the
shadingalias/parameter topygmt.Figure.colorbar.I'm not familiar with how shading will affect the color bar, other than that it makes it look different and darker, so I left a pretty vague description for it under the parameter list.