Conversation
weiji14
left a comment
There was a problem hiding this comment.
I made a suggestion following @leouieda's PR at fatiando/pooch#196. However, I'm not sure if I like this workaround, since we will have to switch from versioneer to setuptools_scm (#671) sooner or later.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
|
See the "fake" release in the test pypi repository: https://test.pypi.org/project/pygmt/0.2.0.post0.dev52/#history |
|
I would actually recommend looking at the workflows here instead: https://github.com/fatiando/boule/tree/master/.github/workflows We're also trying out a tool called nox. It's pretty nice to automate some tasks with Python instead of clunky Makefiles that don't work on Windows. |
weiji14
left a comment
There was a problem hiding this comment.
These changes will have to be documented under MAINTENANCE.md. Could you remove mention of Travis CI PyPI deployments at https://github.com/GenericMappingTools/pygmt/blob/v0.2.0/MAINTENANCE.md#travis-ci and place it under the Github Actions section at https://github.com/GenericMappingTools/pygmt/blob/v0.2.0/MAINTENANCE.md#github-actions instead please?
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
left a comment
There was a problem hiding this comment.
Getting there! Just one minor suggestion to change 'archive' to 'wheel'.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Description of proposed changes
This PR migrate the PyPI release job from Travis CI to GitHub Actions.
References:
Address #566
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Notes
/formatin the first line of a comment to lint the code automatically