Skip to content

Let all tests pass for GMT 6.1.1 and master#668

Merged
seisman merged 5 commits intomasterfrom
pass-tests
Oct 23, 2020
Merged

Let all tests pass for GMT 6.1.1 and master#668
seisman merged 5 commits intomasterfrom
pass-tests

Conversation

@seisman
Copy link
Member

@seisman seisman commented Oct 23, 2020

Description of proposed changes

It's annoying to have failing CI tests. Every time I want to merge a PR, I have to change the branch protection rules, merge a PR, and then change the protection rules back.

This PR contains two changes:

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman marked this pull request as draft October 23, 2020 13:12
@seisman seisman marked this pull request as ready for review October 23, 2020 13:12
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Oct 23, 2020
@weiji14
Copy link
Member

weiji14 commented Oct 23, 2020

Also note that there is a small test failure to do with a line change on test_call_module_error_message (See https://github.com/GenericMappingTools/pygmt/pull/668/checks?check_run_id=1298142572#step:10:454), only for the GMT master branch (i.e. GMT 6.2.0):

E               assert "Module 'info...ogus-data.bla" == "Module 'info...ogus-data.bla"
E                 - Module 'info' failed with status code 71:
E                 ?                                        ^
E                 + Module 'info' failed with status code 72:
E                 ?   

@seisman
Copy link
Member Author

seisman commented Oct 23, 2020

Also note that there is a small test failure to do with a line change on test_call_module_error_message.

Yes, please see this: GenericMappingTools/gmt#4347 (comment).

Although the test failure is caused by upstream change, but I think it's a bad test to check the undocumented status codes. We can see if we can improve the test.

@seisman seisman marked this pull request as draft October 23, 2020 21:59
@seisman seisman marked this pull request as ready for review October 23, 2020 21:59
@seisman
Copy link
Member Author

seisman commented Oct 23, 2020

E               assert "Module 'info...ogus-data.bla" == "Module 'info...ogus-data.bla"
E                 - Module 'info' failed with status code 71:
E                 ?                                        ^
E                 + Module 'info' failed with status code 72:
E                 ?  

Should we check that the status code is 71 for GMT<=6.1.1, and 72 for GMT>=6.2.0? It's really a bad idea to test against the undocumented status codes.

@weiji14
Copy link
Member

weiji14 commented Oct 23, 2020

I would do something like assert "Module 'info' failed with status code" in ..., thus skipping the number check. Or we could do a regex-style check to handle any non-zero number.

@seisman
Copy link
Member Author

seisman commented Oct 23, 2020

Let's wait for more discussions in GenericMappingTools/gmt#4347.

@seisman seisman modified the milestones: 0.2.0, 0.2.1 Oct 23, 2020
@seisman seisman changed the title Let all tests pass Let all tests pass for GMT 6.1.1 and master Oct 23, 2020
@seisman seisman marked this pull request as draft October 23, 2020 22:43
@seisman seisman marked this pull request as ready for review October 23, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants