Add a workflow checking links in plaintext and HTML files#634
Merged
Add a workflow checking links in plaintext and HTML files#634
Conversation
6078a31 to
b906cee
Compare
0b42baa to
b268e7e
Compare
weiji14
reviewed
Jan 20, 2021
a9384e1 to
b344db5
Compare
weiji14
approved these changes
Feb 22, 2021
Member
weiji14
left a comment
There was a problem hiding this comment.
Haven't checked too closely but I trust your Github Actions skills 😄 Only one minor comment but you can ignore it if it's too much work to do.
| - name: Create Issue From File | ||
| uses: peter-evans/create-issue-from-file@v2.3.2 | ||
| with: | ||
| title: Link Checker Report |
Member
There was a problem hiding this comment.
Would be nice to have a unique Issue title (e.g. "Link Checker Report on 28 Feb 2021"), but not essential.
5 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds a workflow to check external links in plaintext and HTML files, using action https://github.com/lycheeverse/lychee-action.
FYI, the workflow takes 50 seconds to check >1000 links. See the workflow runs in https://github.com/GenericMappingTools/pygmt/runs/1931775335?check_suite_focus=true.
Fixes #535
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.