Skip to content

Improve the workflow to test both GMT master and 6.1 branches#554

Merged
seisman merged 3 commits intomasterfrom
multiple-gmt
Aug 6, 2020
Merged

Improve the workflow to test both GMT master and 6.1 branches#554
seisman merged 3 commits intomasterfrom
multiple-gmt

Conversation

@seisman
Copy link
Member

@seisman seisman commented Aug 6, 2020

Description of proposed changes

Test both GMT master and 6.1 branches.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman marked this pull request as draft August 6, 2020 01:08
@seisman seisman marked this pull request as ready for review August 6, 2020 01:08
@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Aug 6, 2020
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor suggestion.

@vercel vercel bot temporarily deployed to Preview August 6, 2020 01:34 Inactive
@seisman seisman requested a review from weiji14 August 6, 2020 01:34
@seisman seisman requested review from weiji14 and removed request for weiji14 August 6, 2020 01:40
@seisman seisman added this to the 0.2.x milestone Aug 6, 2020
@seisman seisman merged commit 3b306c6 into master Aug 6, 2020
@seisman seisman deleted the multiple-gmt branch August 6, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants