Skip to content

Remove the Stickler CI configuration file#538

Merged
seisman merged 2 commits intomasterfrom
stickler
Jul 21, 2020
Merged

Remove the Stickler CI configuration file#538
seisman merged 2 commits intomasterfrom
stickler

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jul 21, 2020 •
edited by weiji14
Loading

Description of proposed changes

Fixes #532.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@stickler-ci
Copy link

stickler-ci commented Jul 21, 2020

I couldn't find a .stickler.yml file in this repository. I can make one for you, or you can create one by following the documentation.

@seisman seisman closed this Jul 21, 2020
@seisman seisman reopened this Jul 21, 2020
@seisman
Copy link
Member Author

seisman commented Jul 21, 2020

@weiji14 I still see the failing check from stickler CI. Am I missing anything?

@weiji14
Copy link
Member

weiji14 commented Jul 21, 2020

I can see that the Stickler Github App is uninstalled. Just merge in the other PR first, update the branch and see if the stickler CI test still shows up.

@seisman
Copy link
Member Author

seisman commented Jul 21, 2020

Never mind. I believe it will disappear after we merge this PR.

weiji14
weiji14 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, the stickler CI test is gone. I've updated the branch protection rules (again) to ensure the "Style Checks" are required for merge.

@seisman seisman added this to the 0.2.x milestone Jul 21, 2020
@seisman seisman added the maintenance Boring but important stuff for the core devs label Jul 21, 2020
@seisman seisman merged commit eb45675 into master Jul 21, 2020
@seisman seisman deleted the stickler branch July 21, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees

No one assigned

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Milestone

0.2.0

Development

Successfully merging this pull request may close these issues.

Remove the Stickler CI service

3 participants

@seisman @stickler-ci @weiji14