Skip to content

Raise an error if short- and long-form arguments coexist#537

Merged
seisman merged 4 commits intomasterfrom
short-long-forms
Jul 21, 2020
Merged

Raise an error if short- and long-form arguments coexist#537
seisman merged 4 commits intomasterfrom
short-long-forms

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jul 18, 2020

Description of proposed changes

Raise an error if both short- and long-form arguments are used. Also add a doctest for it.

See #377 for the bug report.

Fixes #377

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman added the bug Something isn't working label Jul 18, 2020
@seisman seisman added this to the 0.2.x milestone Jul 18, 2020
@seisman
Copy link
Member Author

seisman commented Jul 18, 2020

@weiji14 Any idea to fix the style error?

@seisman seisman merged commit ac28e72 into master Jul 21, 2020
@seisman seisman deleted the short-long-forms branch July 21, 2020 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Short- and long-form kwargs can coexist silently

2 participants