Change load_earth_relief()'s default resolution to 01d#488
Conversation
In GMT 6.0.0, both `01d` and `60m` are valid resolutions of earth relief data. It was called `60m` at the beginning, and was changed to `01d` when GMT 6.0.0 was officially released. `60m` is still valid for backward compatibility. Run the following commands, and you will have the two data in the current directory. ``` gmt which @earth_relief_60m -Gl gmt which @earth_relief_01d -Gl ``` These two files have different file names but are identical: ``` $ md5sum earth_relief_01d.grd earth_relief_60m.grd 74a884c902015dda516d17605f317efe earth_relief_01d.grd 74a884c902015dda516d17605f317efe earth_relief_60m.grd ``` In the upcoming GMT 6.1.0, the resolution `60m` will be deprecated. That's why we have many ~25 errors when testing PyGMT with the GMT master branch, simply because GMT 6.1.0 can't download the `@earth_relief_60m`. To make the transition to GMT 6.1.0 easier, here I change the default earth relief resolution of `load_earth_relief()` function from `60m` to `01d`. As the two grids are identical, the change in this PR won't break anything. Note that, currently there are ~43 failures due to the recent updates of the GMT data server (#451), and we can't fix these failures easily due to the grid registration issue (#476). Thus, I don't try to fix any failures in this PR. The test log files of the master branch and this branch are the same. Tests that fail in the master brach still fail in the same way in this branch.
weiji14
left a comment
There was a problem hiding this comment.
Looks good. I get the same 43 failures locally (on GMT 6.0). Just a few suggestions.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Locally: GitHub new experimental UI: |
|
Ah ok, I always do squash merging via the Github UI and never noticed. Do you just copy the text into your editor and have it cut the line lengths somehow? As for the repository refresh thing, might be good to give feedback at https://support.github.com/contact/feedback?contact%5Bcategory%5D=repo-refresh&contact%5Bsubject%5D=Product+feedback. |
My vim editor seems to be clever to automatically wrap my commit messages to no longer than 80 characters. When do the squash merging, I usually use the line length of the commit messages as a ruler. |
Description of proposed changes
In GMT 6.0.0, both
01dand60mare valid resolutions of earthrelief data. It was called
60mat the beginning, and was changed to01dwhen GMT 6.0.0 was officially released.
60mis still valid for backwardcompatibility.
Run the following commands, and you will have the two data in the
current directory.
These two files have different file names but are identical:
In the upcoming GMT 6.1.0, the resolution
60mwill be deprecated.That's why we have many ~25 errors when testing PyGMT with the GMT master
branch, simply because GMT 6.1.0 can't download the
@earth_relief_60m.To make the transition to GMT 6.1.0 easier, here I change the default
earth relief resolution of
load_earth_relief()function from60mto01d. As the two grids are identical, the change in this PR won't breakanything.
Note that, currently there are ~43 failures due to the recent updates of
the GMT data server (#451), and we can't fix these failures easily due
to the grid registration issue (#476). Thus, I don't try to fix any
failures in this PR.
I also added some valid resolutions (e.g., 20m, 15m) which are missing.
The test log files (master.log and current-branch.log) of the master branch and this branch are the same.
Tests that fail in the master branch still fail in the same way in this branch.
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.