Skip to content

Patch release drafter github action#457

Merged
seisman merged 1 commit intomasterfrom
quickfix-release-drafter
May 25, 2020
Merged

Patch release drafter github action#457
seisman merged 1 commit intomasterfrom
quickfix-release-drafter

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented May 25, 2020

Description of proposed changes

Should not have a blank YAML under with. See error at https://github.com/GenericMappingTools/pygmt/actions/runs/114391531. Patches #446.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Should not have a blank YAML under `with`.
@weiji14 weiji14 added the skip-changelog Skip adding Pull Request to changelog label May 25, 2020
@weiji14
Copy link
Member Author

weiji14 commented May 25, 2020

@seisman, I need to head out so feel free to merge this if it works (or push any changes to this branch). Remember to re-enable the checks later.

@seisman seisman merged commit cf6efd9 into master May 25, 2020
@seisman seisman deleted the quickfix-release-drafter branch May 25, 2020 05:05
@seisman seisman added this to the 0.2.x milestone May 25, 2020
@weiji14 weiji14 mentioned this pull request May 25, 2020
7 tasks
@weiji14 weiji14 modified the milestones: 0.2.x, 0.1.x Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants