geopandas: Fix UnicodeEncodeError on Windows for geopandas.GeoDataFrame with non-ASCII characters#4224
Merged
geopandas: Fix UnicodeEncodeError on Windows for geopandas.GeoDataFrame with non-ASCII characters#4224
Conversation
Member
Author
|
@yvonnefroehlich This PR should fix the issue you had in GenericMappingTools/pygmt-paper-figures#6 (comment). |
weiji14
approved these changes
Nov 25, 2025
| gdf = gpd.GeoDataFrame( | ||
| { | ||
| "name_ascii": ["Fiji"], | ||
| "name_utf8": ["فيجي"], # Arabic |
Member
There was a problem hiding this comment.
Can confirm that this is Fiji in Arabic 😆
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Member
|
Ah, OK. Thanks for looking at this 🙂. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test for geopandas with non-ASCII characters, which doesn't work on Windows (https://github.com/GenericMappingTools/pygmt/actions/runs/19654941294/job/56289538628?pr=4224):
This PR fixes the issue by setting
encoding="UTF-8"when writing geopandas to ORG_GMT file.