Skip to content

Remove mention of gitter.im#405

Merged
leouieda merged 2 commits intomasterfrom
gitter_removal
Mar 26, 2020
Merged

Remove mention of gitter.im#405
leouieda merged 2 commits intomasterfrom
gitter_removal

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented Mar 26, 2020

Description of proposed changes

Following up from #404, I noticed some old gitter webhooks that still points to the old gmt-python gitter chatroom 🤦‍♂️.

This PR will basically revert the gitter.im webhook integrations added in #36, and other instances of gitter. Questions should now be redirected to https://forum.generic-mapping-tools.org. New users trying to join the gitter chatroom will see this welcome message:

gitter welcome message telling them to go to https://forum.generic-mapping-tools.org

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Basically reverting the gitter.im webhook integrations added in #36. Questions should now be redirected to https://forum.generic-mapping-tools.org.
@weiji14 weiji14 self-assigned this Mar 26, 2020
Remove gitter.im contact point as it is not active anymore. Users should post questions/comments on the forum instead.
@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Mar 26, 2020
@weiji14 weiji14 marked this pull request as ready for review March 26, 2020 03:32
Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me. We have to start chatting a bit more 🙂

@leouieda leouieda merged commit d29a1a6 into master Mar 26, 2020
@leouieda leouieda deleted the gitter_removal branch March 26, 2020 09:01
@weiji14
Copy link
Member Author

weiji14 commented Mar 26, 2020

We should, my place has gone very quiet with the lockdown! Stay sane over there, and hope that your family is well 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants