Skip to content

Add the GMT/PyGMT preworkshop at AGU24 to the "External resources" section#3689

Merged
seisman merged 6 commits intomainfrom
add-agu24-preworkshop
Dec 23, 2024
Merged

Add the GMT/PyGMT preworkshop at AGU24 to the "External resources" section#3689
seisman merged 6 commits intomainfrom
add-agu24-preworkshop

Conversation

@yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Dec 14, 2024 •
edited
Loading

Description of proposed changes

Add the GMT/PyGMT preworkshop at AGU24 to the "External resources" section:

Preview: https://pygmt-dev--3689.org.readthedocs.build/en/3689/external_resources.html

Fixes: #3683 (partly)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added the maintenance Boring but important stuff for the core devs label Dec 14, 2024
@yvonnefroehlich yvonnefroehlich added this to the 0.14.0 milestone Dec 14, 2024
@yvonnefroehlich yvonnefroehlich self-assigned this Dec 14, 2024
@seisman
Copy link
Member

seisman commented Dec 16, 2024

@yvonnefroehlich It seems the thumbnail image for the "PyGMT-Howto" tutorial is also broken. Please help fix it in this PR.

@seisman seisman added documentation Improvements or additions to documentation and removed maintenance Boring but important stuff for the core devs labels Dec 16, 2024
@seisman seisman changed the title List the GMT/PyGMT preworkshop at AGU24 in the "External resources" section Add the GMT/PyGMT preworkshop at AGU24 in the "External resources" section Dec 16, 2024
@yvonnefroehlich yvonnefroehlich mentioned this pull request Dec 16, 2024
Closed
49 tasks
@yvonnefroehlich
Copy link
Member Author

yvonnefroehlich commented Dec 16, 2024

@yvonnefroehlich It seems the thumbnail image for the "PyGMT-Howto" tutorial is also broken. Please help fix it in this PR.

The URL is updated in commit cdcc26e.

@yvonnefroehlich
Copy link
Member Author

yvonnefroehlich commented Dec 19, 2024

thumbnail_preworkshop

@seisman
Copy link
Member

seisman commented Dec 19, 2024

I just downloaded the image and upload it again. Here is the link I have:

https://github.com/user-attachments/assets/f92e1391-78f4-41bc-8ed8-5df1f59b8362

seisman
seisman approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 19, 2024
weiji14
weiji14 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @yvonnefroehlich!

doc/external_resources.md Outdated
:text-align: center
:margin: 0 3 0 0

![](https://github.com/user-attachments/assets/f92e1391-78f4-41bc-8ed8-5df1f59b8362)
Copy link
Member

@weiji14 weiji14 Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a slightly taller screenshot?

Suggested change
![](https://github.com/user-attachments/assets/f92e1391-78f4-41bc-8ed8-5df1f59b8362)
![](https://github.com/user-attachments/assets/9f3ab0ed-83f1-4cff-bc68-387fc13ca61f)

image

Copy link
Member Author

@yvonnefroehlich yvonnefroehlich Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer to show the figure of Tutorial 4 completely, but there is already quite a lot white space when using the current screenshot in the neighboring cards, so I was unsure using a taller screenshot. But let's try and see how it looks.

screenshot with cut Tutorial 4 screenshot with complete Tutorial 4
preworkshop_externalresources_whitespace preworkshop_externalresources_complete_whitespace

Copy link
Member

@seisman seisman Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this one? The title is removed from the screenshot.
Screenshot from 2024-12-21 12-12-25

https://github.com/user-attachments/assets/b86fd4c1-c5dd-4d51-a7fe-362d86cc01b0

Copy link
Member Author

@yvonnefroehlich yvonnefroehlich Dec 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I thought about not including the title in the screenshot, but kept it to be consistent with the image for the EGU2022 workshop. But let's see how it looks after 2e8b38e:

screenshot with cut Tutorial 4 screenshot with complete Tutorial 4 screenshot without title
preworkshop_externalresources_whitespace_01 preworkshop_externalresources_complete_whitespace preworkshop_externalresources_notitle_whitespace

Copy link
Member

@seisman seisman Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can choose anyone you like, then merge this PR.

yvonnefroehlich and others added 2 commits December 20, 2024 23:56
@yvonnefroehlich @weiji14
Use talker screenshot (show tut4 completely)
25c84b1 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@yvonnefroehlich
Use image without title
2e8b38e
@yvonnefroehlich yvonnefroehlich changed the title Add the GMT/PyGMT preworkshop at AGU24 in the "External resources" section Add the GMT/PyGMT preworkshop at AGU24 to the "External resources" section Dec 22, 2024
@yvonnefroehlich yvonnefroehlich mentioned this pull request Dec 22, 2024
Closed
2 tasks
@seisman seisman merged commit 3858513 into main Dec 23, 2024
@seisman seisman deleted the add-agu24-preworkshop branch December 23, 2024 00:41
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 23, 2024
@seisman seisman mentioned this pull request Dec 23, 2024
Open
@yvonnefroehlich yvonnefroehlich mentioned this pull request Dec 25, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seisman seisman seisman approved these changes

@weiji14 weiji14 weiji14 approved these changes

Assignees

@yvonnefroehlich yvonnefroehlich

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

0.14.0

Development

Successfully merging this pull request may close these issues.

3 participants

@yvonnefroehlich @seisman @weiji14