Add legend gallery entry#358
Merged
weiji14 merged 5 commits intoGenericMappingTools:masterfrom Nov 1, 2019
liamtoney:legend-gallery
Merged
Add legend gallery entry#358weiji14 merged 5 commits intoGenericMappingTools:masterfrom liamtoney:legend-gallery
weiji14 merged 5 commits intoGenericMappingTools:masterfrom
liamtoney:legend-gallery
Conversation
weiji14
requested changes
Nov 1, 2019
Member
weiji14
left a comment
There was a problem hiding this comment.
I'm thinking whether we should combine the colorbar and legend examples into a full tutorial, considering that the position justification, offset and lots of things are similar. But let's keep it simple for now.
Co-Authored-By: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-Authored-By: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
approved these changes
Nov 1, 2019
Member
weiji14
left a comment
There was a problem hiding this comment.
Ok, I'll approve this, but I noticed that the legend docstring at https://www.pygmt.org/dev/api/generated/pygmt.Figure.legend.html has this text
b) a list containing a list of figure handles and a list of corresponding labels.
which I think is a hangover from your regex work 😢 Probably should fix that otherwise people will get confused. You can do that in #359.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Just adding a legend example to the gallery.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.