Improve the data type checking for 2-D arrays passed to the GMT C API#3563
Merged
Improve the data type checking for 2-D arrays passed to the GMT C API#3563
Conversation
weiji14
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some factors you should know:
_check_dtype_and_dimfunction is used input_vectorsandput_matrixonlyGMT_Put_Matrix(i.e.,put_matrix) can only accept 2-D arrays with numeric dtypes (e.g.,GMT_INT)GMT_Put_Vectors(i.e.,put_vectors) can accept 1-D arrays in both numeric dtypes (e.g.,GMT_INT) and text dtypes (e.g.,GMT_TEXT/GMT_DATETIME)Previously, we check if the array dtype exists in the
DTYPESdict for both 1-D and 2-D arrays. This PR splitsDTYPESintoDTYPES_NUMERICandDTYPES_TEXT, and explicitly check if 2-D array dtype inDTYPES_NUMERIC.