Add a test to make sure PyGMT works with paths that contain non-ASCII characters#3280
Merged
Add a test to make sure PyGMT works with paths that contain non-ASCII characters#3280
Conversation
weiji14
approved these changes
Jul 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds a new test to check if PyGMT works on a user account that has non-ASCII characters (e.g., Chinese characters). The issue is initially reported in #3279.
It turns out GMT and PyGMT work well on Linux/macOS, but don't work on Windows. On Windows, the errors are like:
There are two main issues:
gmt_mkdirreports errors "Invalid argument"(null)/gmt_data_server.txtis incorrect, which meansGMT->session.USERDIR=NULLIt's because when
gmt_mkdirfails, GMT freesGMT->session.USERDIR(https://github.com/GenericMappingTools/gmt/blob/1c8a78b0613a227f406303930ebcf7238ad3401d/src/gmt_init.c#L3826). ChatGPT told me that themkdirfunction on Windows doesn't support multi-byte characters. So I guess that's the reason and the test is skipped on Windows (I may find some time debugging this in the future but not now).