Skip to content

Splitting of the projections gallery into projection types and complete the examples for azimuthal projections#318

Merged
leouieda merged 18 commits intoGenericMappingTools:masterfrom
phloose:gallery-plots
Aug 1, 2019
Merged

Splitting of the projections gallery into projection types and complete the examples for azimuthal projections#318
leouieda merged 18 commits intoGenericMappingTools:masterfrom
phloose:gallery-plots

Conversation

@phloose
Copy link
Contributor

@phloose phloose commented Jul 31, 2019

This pull request adds sub sections in the projection examples gallery for the five main projection groups that GMT supports and completes the azimuthal projection examples.

Related to #292

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@welcome
Copy link

welcome bot commented Jul 31, 2019

💖 Thanks for opening this pull request! 💖

Please make sure you read our contributing guidelines and abide by our code of conduct.

A few things to keep in mind:

  • If you need help writing tests, take a look at the existing ones for inspiration. If you don't know where to start, let us know and we'll walk you through it.
  • All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
  • No matter what, we are really grateful that you put in the effort to do this! 🎉

leouieda
leouieda requested changes Aug 1, 2019
View reviewed changes
Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xibalba01 thanks for doing all this work! I made a few minor corrections to the text. Please see if you agree and after they're all addressed we can merge this in.

phloose and others added 9 commits August 1, 2019 19:24
@phloose @leouieda
Update examples/projections/azim/azim_gnomonic.py
9660698 
Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
@phloose @leouieda
Update examples/projections/azim/azim_general_perspective.py
188914e 
Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
@phloose @leouieda
Update examples/projections/azim/azim_general_stereographic.py
ee7d534 
Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
@phloose @leouieda
Update examples/projections/azim/azim_general_stereographic.py
6f38bcc 
Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
@phloose @leouieda
Update examples/projections/azim/azim_general_stereographic.py
4b98161 
Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
@phloose @leouieda
Update examples/projections/azim/azim_general_stereographic.py
7f83ce3 
Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
@phloose @leouieda
Update examples/projections/azim/azim_orthographic.py
4cf40e0 
Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
@phloose @leouieda
Update examples/projections/azim/azim_orthographic.py
7fa34ff 
Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
@phloose @leouieda
Update examples/projections/azim/azim_general_stereographic.py
efab82a 
Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
@leouieda leouieda merged commit 82e9c92 into GenericMappingTools:master Aug 1, 2019
@welcome
Copy link

welcome bot commented Aug 1, 2019

🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉

Please open a new pull request to add yourself to the AUTHORS.md file. We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@leouieda
Copy link
Member

leouieda commented Aug 1, 2019

Thanks @xibalba01! This was great. Looking forward to new contributions in the future 👍

@phloose
Copy link
Contributor Author

phloose commented Aug 1, 2019

Glad i could help a bit @leouieda! Looking forward, too!

@weiji14 weiji14 added this to the 0.1.0 milestone Oct 4, 2019
This was referenced Dec 17, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leouieda leouieda leouieda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.1.x

Development

Successfully merging this pull request may close these issues.

3 participants

@phloose @leouieda @weiji14