Conversation
Stamen basemaps are being deprecated, so switching the default source to OpenStreetMap Humanitarian web tiles following contextily. Changed load_tile_map's inline example to use OpenTopoMap, and tilemap gallery example to use USGS's USImageryTopo instead.
examples/gallery/maps/tilemaps.py
Outdated
| # Use the U.S. Geological Survey Imagery Topo web tiles from contextily | ||
| source=contextily.providers.USGS.USImageryTopo, |
There was a problem hiding this comment.
The USImageryTopo map looks like this:
Alternatively, I was also thinking that the CartoDB basemaps could be a good option (that is also global in coverage). E.g. CartoDB Positron which has a lighter colour and might be better to overlay other data on top:
Any preference, or other options to consider?
There was a problem hiding this comment.
I was also thinking that the CartoDB basemaps could be a good option (that is also global in coverage). E.g. CartoDB Positron which has a lighter colour and might be better to overlay other data on top:
Sounds good to me.
|
Noticing that __________________________ test_tilemap_web_mercator ___________________________
args = (), kwargs = {}
def wrapper(*args, **kwargs):
> store.return_value[test_name] = obj(*args, **kwargs)
../../../../micromamba/envs/pygmt/lib/python3.11/site-packages/pytest_mpl/plugin.py:107:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
../pygmt/tests/test_tilemap.py:17: in test_tilemap_web_mercator
fig.tilemap(
../pygmt/helpers/decorators.py:598: in new_module
return module_func(*args, **kwargs)
../pygmt/helpers/decorators.py:738: in new_module
return module_func(*args, **kwargs)
../pygmt/src/tilemap.py:148: in tilemap
lib.call_module(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <pygmt.clib.session.Session object at 0x7f877c8b63d0>
module = 'grdimage'
args = '/tmp/pygmt-ih40ojsv.tif -Bafg -R-20000000.0/20000000.0/-20000000.0/20000000.0'
def call_module(self, module, args):
"""
Call a GMT module with the given arguments.
Makes a call to ``GMT_Call_Module`` from the C API using mode
``GMT_MODULE_CMD`` (arguments passed as a single string).
Most interactions with the C API are done through this function.
Parameters
----------
module : str
Module name (``'coast'``, ``'basemap'``, etc).
args : str
String with the command line arguments that will be passed to the
module (for example, ``'-R0/5/0/10 -JM'``).
Raises
------
GMTCLibError
If the returned status code of the function is non-zero.
"""
c_call_module = self.get_libgmt_func(
"GMT_Call_Module",
argtypes=[ctp.c_void_p, ctp.c_char_p, ctp.c_int, ctp.c_void_p],
restype=ctp.c_int,
)
mode = self["GMT_MODULE_CMD"]
status = c_call_module(
self.session_pointer, module.encode(), mode, args.encode()
)
if status != 0:
> raise GMTCLibError(
f"Module '{module}' failed with status code {status}:\n{self._error_message}"
)
E pygmt.exceptions.GMTCLibError: Module 'grdimage' failed with status code 79:
Error: grdimage [ERROR]: Byte image without indexed color requires a CPT via -C
../pygmt/clib/session.py:628: GMTCLibError
----------------------------- Captured stderr call -----------------------------
Error: e [ERROR]: Byte image without indexed color requires a CPT via -C |
Switch from USGS Imagery Topo basemap to CartoDB Positron that is lighter in colour and suited for overlaying point data on top.
|
Change the PR title to something like? |
Mm, but there are also some changes to |
Then maybe The main idea is to use the PR title in the changelog so that it's easy to know the "breaking" changes in the future. |
|
The default tile provider actually depends on what version of |
I see.
Sounds good. Then then PR title doesn't matter much now. |
|
Ok, I'll merge this in then. |


Description of proposed changes
Stamen basemaps are being deprecated, so switching the default source to OpenStreetMap Humanitarian web tiles following contextily at geopandas/contextily#221. Changed load_tile_map's inline example to use OpenTopoMap, and tilemap gallery example to use CartoDB's Positron basemap instead.
Preview at https://pygmt-dev--2717.org.readthedocs.build/en/2717/gallery/maps/tilemaps.html
Fixes #2716
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version