Skip to content

Figure.colorbar: Add alias for "Q"#2608

Merged
seisman merged 49 commits intoGenericMappingTools:mainfrom
jhtong33:add-alias-Q-colorbar
Jul 21, 2023
Merged

Figure.colorbar: Add alias for "Q"#2608
seisman merged 49 commits intoGenericMappingTools:mainfrom
jhtong33:add-alias-Q-colorbar

Conversation

@jhtong33
Copy link
Contributor

@jhtong33 jhtong33 commented Jul 18, 2023

Description of proposed changes
As title, the PR aims to add alias "Q" for colorbar

Fixes #2607

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

jhtong33 and others added 30 commits January 11, 2023 12:44
@jhtong33
alias surface.py T=tensor
9007170
@jhtong33
surface.py add tension documnets
4b62f0e
@jhtong33
surface add -L -M -C:
803a278
@jhtong33 @weiji14
Apply suggestions from code review
fc0ba08 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@jhtong33
surface add document: limit upper & lower
fbe59e2
@jhtong33 @weiji14
Apply suggestions from code review
6cf98c8 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@jhtong33 @weiji14
Apply suggestions from code review
f917d9d 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
/format
add6d0a
format
5c77c5f
@jhtong33
format bold and space
ae90cc3
@jhtong33 @yvonnefroehlich
Apply suggestions from code review
9d19405 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@jhtong33 @yvonnefroehlich
Apply suggestions from code review
38e80c0 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@jhtong33
add Unit links
68f7fbf
@jhtong33
add Unit links with :
78f721c
@jhtong33
add Unit links
15680a7
@jhtong33
Merge branch 'GenericMappingTools:main' into main
d05a7a5
@jhtong33
adding grdgradient_shading
c6fcf49
@actions-bot
[format-command] fixes
bffc4c2
@jhtong33 @weiji14 @yvonnefroehlich
Apply suggestions from code review
8c9505a 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@jhtong33
code finish
e5f5c54
@jhtong33
Merge branch 'GenericMappingTools:main' into mini_branch
1fdc625
@weiji14
Merge branch 'main' into main
2897d2f
@jhtong33 @seisman
Apply suggestions from code review
3256f2b 
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@jhtong33
add tension more infomation
2d433b0
@jhtong33
Merge branch 'main' of github.com:JingHuiTong/pygmt into main
1492de9
@jhtong33
mini_branch/ surface.py T=tension more information
3c8fd2c
@jhtong33
Fix conflicts
968bda3
@jhtong33
Merge remote-tracking branch 'origin/main' into main
6136b8a
@actions-bot
[format-command] fixes
5653ef1
@jhtong33 @weiji14 @yvonnefroehlich
Apply suggestions from code review
8da18ee 
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@jhtong33
Copy link
Contributor Author

jhtong33 commented Jul 18, 2023

/format

@jhtong33 jhtong33 self-assigned this Jul 18, 2023
@michaelgrund michaelgrund added feature request New feature wanted enhancement Improving an existing feature and removed feature request New feature wanted labels Jul 18, 2023
michaelgrund
michaelgrund reviewed Jul 18, 2023
View reviewed changes
@yvonnefroehlich yvonnefroehlich changed the title pygmt.colorbar: Add alias "Q" Figure.colorbar: Add alias "Q" Jul 18, 2023
yvonnefroehlich
yvonnefroehlich reviewed Jul 18, 2023
View reviewed changes
@jhtong33 @yvonnefroehlich @michaelgrund
Apply suggestions from code review
76293c6 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
@jhtong33 jhtong33 added this to the 0.10.0 milestone Jul 19, 2023
@jhtong33 jhtong33 added the needs review This PR has higher priority and needs review. label Jul 19, 2023
michaelgrund
michaelgrund approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jul 20, 2023
@seisman seisman merged commit b32e6d7 into GenericMappingTools:main Jul 21, 2023
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jul 21, 2023
@yvonnefroehlich yvonnefroehlich changed the title Figure.colorbar: Add alias "Q" Figure.colorbar: Add alias for "Q" Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yvonnefroehlich yvonnefroehlich yvonnefroehlich left review comments

@seisman seisman seisman approved these changes

@michaelgrund michaelgrund michaelgrund approved these changes

Assignees

@jhtong33 jhtong33

Labels

enhancement Improving an existing feature

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

Adding colorbar -Q

6 participants

@jhtong33 @seisman @michaelgrund @yvonnefroehlich @actions-bot @weiji14