Figure.meca: Add a test for passing event names via pandas.DataFrame#2582
Merged
Figure.meca: Add a test for passing event names via pandas.DataFrame#2582
Conversation
b639aea to
c1228c0
Compare
Member
Author
|
/test-gmt-dev |
Member
Author
|
The "DVC image diff" workflow failure will be fixed in #2583 |
Contributor
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)DetailsAdded imagesModified images
Report last updated at commit 4208dda |
michaelgrund
approved these changes
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of proposed changes
See #2524 for context.
The failure is caused by an upstream bug, which was already fixed in GenericMappingTools/gmt#7557.
In this PR, I renamed the old
test_meca_dict_eventnametest totest_meca_eventname, and add a new test following #2524. The new test passes in the "GMT Tests Dev" workflow (https://github.com/GenericMappingTools/pygmt/actions/runs/5346800096) and is skipped in the "Tests" workflow (because it crashes with GMT 6.4)Fixes #2524
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version