Skip to content

Document the default CPT for GMT remote datasets#2573

Merged
seisman merged 13 commits intomainfrom
dataset-cpt
Jul 4, 2023
Merged

Document the default CPT for GMT remote datasets#2573
seisman merged 13 commits intomainfrom
dataset-cpt

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jun 12, 2023 •
edited by yvonnefroehlich
Loading

seisman
seisman commented Jun 12, 2023
View reviewed changes
@seisman seisman added documentation Improvements or additions to documentation needs review This PR has higher priority and needs review. labels Jun 12, 2023
@seisman seisman added this to the 0.10.0 milestone Jun 12, 2023
yvonnefroehlich
yvonnefroehlich reviewed Jun 12, 2023
View reviewed changes
michaelgrund
michaelgrund reviewed Jun 12, 2023
View reviewed changes
seisman and others added 2 commits June 12, 2023 20:50
@seisman @michaelgrund @yvonnefroehlich
Apply suggestions from code review
78cea31 
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman
Fix styling
7994678
yvonnefroehlich
yvonnefroehlich reviewed Jun 13, 2023
View reviewed changes
seisman and others added 3 commits June 14, 2023 07:04
@seisman @yvonnefroehlich
Update pygmt/datasets/earth_age.py
a383357 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman
Merge branch 'main' into dataset-cpt
df0534d
@seisman
Update more datasets
27b28e2
@seisman seisman changed the title RFC: Document the default CPT for GMT remote datasets Document the default CPT for GMT remote datasets Jun 14, 2023
yvonnefroehlich
yvonnefroehlich reviewed Jun 18, 2023
View reviewed changes
seisman and others added 3 commits June 19, 2023 08:08
@seisman @yvonnefroehlich
Update pygmt/datasets/earth_magnetic_anomaly.py
eaed409 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman
Fix style
9b2ef83
@seisman
Merge branch 'main' into dataset-cpt
572ca58
@seisman
Copy link
Member Author

seisman commented Jun 24, 2023

Ping @GenericMappingTools/pygmt-maintainers for review.

@seisman seisman requested a review from a team July 2, 2023 02:28
yvonnefroehlich
yvonnefroehlich approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine!
Just one minor comment.

@seisman @yvonnefroehlich
Update pygmt/datasets/earth_magnetic_anomaly.py
d498f31 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jul 3, 2023
@seisman seisman merged commit 2413b61 into main Jul 4, 2023
@seisman seisman deleted the dataset-cpt branch July 4, 2023 08:25
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelgrund michaelgrund michaelgrund left review comments

@yvonnefroehlich yvonnefroehlich yvonnefroehlich approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman @michaelgrund @yvonnefroehlich